Skip to content

processor: add exact continuation stack limit regression test#2995

Merged
huitseeker merged 5 commits into0xMiden:nextfrom
KitaroMoha563:test-processor-exact-continuation-limit
Apr 24, 2026
Merged

processor: add exact continuation stack limit regression test#2995
huitseeker merged 5 commits into0xMiden:nextfrom
KitaroMoha563:test-processor-exact-continuation-limit

Conversation

@KitaroMoha563
Copy link
Copy Markdown
Contributor

@KitaroMoha563 KitaroMoha563 commented Apr 13, 2026 •
edited
Loading

Describe your changes

Follow-up to #2825.

Add a regression test that proves execution still succeeds when the continuation stack size is exactly equal to max_num_continuations.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Commits are signed.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.
  • Updated CHANGELOG.md

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

Automated check (CONTRIBUTING.md)

Findings:

Recommendations:

  • Consider adding a Test plan or clear review steps.

Next steps:

  • Link a relevant issue (e.g., "Fixes Implement SHA256 in Miden Assembly #123") and ensure it is assigned to you.
  • See CONTRIBUTING.md for expectations.
  • If this is a false positive, comment: /quality-review.

@KitaroMoha563
Copy link
Copy Markdown
Contributor Author

KitaroMoha563 commented Apr 13, 2026

The cargo-deny error appears to be the existing rand 0.9.2 version issue, not something introduced by this PR.

huitseeker
huitseeker previously approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huitseeker huitseeker dismissed their stale review April 13, 2026 15:48

Changelog issue

huitseeker
huitseeker reviewed Apr 13, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
@KitaroMoha563
Copy link
Copy Markdown
Contributor Author

KitaroMoha563 commented Apr 15, 2026

@huitseeker Done, thanks very much for your review!

huitseeker
huitseeker approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@huitseeker huitseeker merged commit f84b0ff into 0xMiden:next Apr 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees

No one assigned

Labels

quality-concern

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KitaroMoha563 @huitseeker